-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stage level metrics output csv file #1251
Conversation
Signed-off-by: Niranjan Artal <[email protected]>
rapids-tools-pr-1251.patch The output now looks like this:
|
Signed-off-by: Niranjan Artal <[email protected]>
Thanks @amahussein! The output looks cleaner now. Have applied the patch in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nartal1 for this fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nartal1 for the fix.
This fixes #1250.
This bug is because of grouping the metrics only on accumId. This PR fixes the bug by grouping it both on accumId and stageId such that the result is metrics per stage.
Changed the unit test such that the same accumId is updated in 2 stages and the output will show it in 2 different rows.
Also tested it on custom eventlog where the accumulator updates the value in 2 stages.
Before this PR:
With this PR: