Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate records in DataSourceInfo report #1227

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

amahussein
Copy link
Collaborator

Signed-off-by: Ahmed Hussein (amahussein) [email protected]

Fixes #1182

  • this PR fixes duplicate records in data_source_infor.csv
  • optimizes the implementation by cachine the Seq[SQLAccumProfileResults]

See the bug analysis in the comment #1182 (comment)

Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Fixes NVIDIA#1182

- this PR fixes duplicate records in data_source_infor.csv
- optimizes the implementation by cachine the `Seq[SQLAccumProfileResults]`
@amahussein amahussein added bug Something isn't working core_tools Scope the core module (scala) labels Jul 24, 2024
@amahussein amahussein self-assigned this Jul 24, 2024
Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein ! This fix LGTM.

Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein for fixing this.

Copy link
Collaborator

@cindyyuanjiang cindyyuanjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein!

@amahussein amahussein merged commit 741e8b1 into NVIDIA:dev Jul 25, 2024
15 checks passed
@amahussein amahussein deleted the spark-rapids-tools-1182 branch July 25, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] data_source_information inside raw_metrics duplicates the rows
4 participants