-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate summary metadata file and fix node recommendation in python #1216
Conversation
Signed-off-by: Partho Sarthi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- If we are generating a new file
qualification_summary_metadata.json
do we get rid of the previous file that was showing source/target clusters? - I am not 100% yet on what would be that file name. too many
qualification_summary*
on the root level. - in the PR description, I cannot see the same notes in "before" and "after"
OutputNode Recommendation FixCMD:
Before: Incorrect Node Recommendation
After: Correct Node Recommendation
|
Thanks @amahussein.
Yes, the previous file has been removed since it contained only cluster information.
As part of #1099, we should get rid of summary csv grouped by name. In that case we will have only two files:
There seems to be some rendering issue in Github markdown due to special characters. Added it as a separate comment above. |
Signed-off-by: Partho Sarthi <[email protected]>
Signed-off-by: Partho Sarthi <[email protected]>
Signed-off-by: Partho Sarthi <[email protected]>
filed #1239 to followup on this |
Fixes #1143 , Fixes #1215.
This PR introduces the following and some code refactoring:
qualification_summary_metadata.json
.Code Changes
ClusterConfigRecommender
that cleans up the code by tying together the following:qualification.py::_write_summary_metadata()
(issue-1143)qualification.py::__infer_cluster_for_auto_tuning()
(issue-1215)Output
Metadata JSON
File: `qual_20240723160911_B043Bae0/qualification_summary_metadata.json`
Node Recommendation Fix
See below. Added as a separate comment for readability
To Discuss:
cluster_inference.py::get_cluster_template_args ()
'Recommended Executor Instance'
while creating CPU instance object.sections_generators=[self.__generate_mc_types_conversion_report],
__generate_mc_types_conversion_report()
Follow Up