-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include status information for failed event logs in core tool #1187
Conversation
Signed-off-by: Partho Sarthi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @parthosa !
LGTME.
Missing copyrights
so this is just for the scala code then? |
Signed-off-by: Partho Sarthi <[email protected]>
Yes @tgravescs.. This PR is for only for the scala code.
Follow up issue for the python tool to rollup this information - #1126 |
# Conflicts: # core/src/main/scala/com/nvidia/spark/rapids/tool/EventLogPathProcessor.scala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Partho
my question is answered don't wait on me for anything |
Fixes #1164. This PR generates status reports for event logs that failed due to an exception (i.e. File Not Found, Authentication or any other CSP exceptions) in the
rapids_4_spark_qualification_output_status.csv
file.CMD:
Output
File:
qual_2024xxx/rapids_4_spark_qualification_output/rapids_4_spark_qualification_output_status.csv
After this change:
Previously
Changes:
FailedEventLog
as a wrapper for failed event logsgetEventLogInfo()
to returnFailedEventLog
for failed casesToolBase
that initialises some of the common variables for both Q/P ToolhandleFailedEventLogs()
to add failed event log to the status reportTesting
Notes