Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing assignment to savings_recommendations #1098

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

amahussein
Copy link
Collaborator

Signed-off-by: Ahmed Hussein (amahussein) [email protected]

Fixes #1097

  • set the savings_recommendations to default value "Not Recommended"
  • Fix DataFrame warnings returning-a-view-versus-a-copy

Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Fixes NVIDIA#1097

- set the savings_recommendations to default value "Not Recommended"
- Fix DataFrame warnings returning-a-view-versus-a-copy
@amahussein amahussein added bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python) labels Jun 10, 2024
@amahussein amahussein self-assigned this Jun 10, 2024
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein. LGTM.

@amahussein amahussein merged commit 63b2edb into NVIDIA:dev Jun 10, 2024
15 checks passed
@amahussein amahussein deleted the spark-rapids-tools-1097 branch June 10, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] savings_recommendations referenced before assignment in user-tools
2 participants