Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing appEndTime in raw_metrics folder #1092

Conversation

amahussein
Copy link
Collaborator

Signed-off-by: Ahmed Hussein (amahussein) [email protected]

Fixes #1091

Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Fixes NVIDIA#1091
@amahussein amahussein added bug Something isn't working core_tools Scope the core module (scala) labels Jun 7, 2024
@amahussein amahussein self-assigned this Jun 7, 2024
@amahussein amahussein changed the title fix missing appEndTime in raw_metrics folder Fix missing appEndTime in raw_metrics folder Jun 7, 2024
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein for this fix. LGTM.

@@ -499,7 +492,8 @@ class QualificationAppInfo(
*/
def aggregateStats(): Option[QualificationSummaryInfo] = {
appMetaData.map { info =>
val appDuration = calculateAppDuration(info.startTime).getOrElse(0L)
val appDuration = calculateAppDuration().getOrElse(0L)
//calculateAppDuration(info.startTime).getOrElse(0L)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This can be removed.

Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein !

@amahussein amahussein merged commit 597f722 into NVIDIA:dev Jun 7, 2024
16 checks passed
@amahussein amahussein deleted the spark-rapids-tools-fix-profile-aggregatedtiming branch June 7, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The raw_metrics CSV file miss App endTime and appDuration
3 participants