Migrate to issue forms #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced May 13, 2022
|
Thanks @TheEvilSkeleton for the suggestion and PR. |
|
Here we go. :) Thanks for the nudge! |
Daasin
added a commit
to Daasin/OPU-Kernel-Modules
that referenced
this pull request
Nov 23, 2022
* moved array sanity check to before the array access * Fixed some typos * [~] Fix typos in NVDEC Engine Descriptor * Fixed capitalization * Create CONTRIBUTING.md * use github forms for issue flow management, fixes NVIDIA#127 * issue template: add automatic tags * Update HTTP link to HTTPS http://www.nvidia.com redirects to https://www.nvidia.com/, so linking to http is reduntant. More importantly, it could be considered a security issue, do to the nature of plain http. An attacker could perform a MITM attack and redirect the HTTP request to a malicious website. ``` > GET / HTTP/1.1 > Host: www.nvidia.com Response: < HTTP/1.1 307 Temporary Redirect < Location: https://www.nvidia.com/ ``` * Fix shellcheck errors in conftest * Remove non-posix local usage from conftest * Remove trailing whitespace from conftest * 515.48.07 * 515.57 * update CONTRIBUTING.md to explain cosmetics policy Also adds a blurb about the missing code style guide. * nv-pci: Fix nullptr dereference if device was not found Closes NVIDIA#57 * dp_configcaps: Avoid querying bus if both bLinkActive and bLinkReady is NULL Doesn't fix a crash -- but avoids redundant work due to a copy paste error. Closes NVIDIA#56 * osapi: Fix dereferencing NULL pNumaMemSize in rm_get_gpu_numa_info Copy paste error. Closes: NVIDIA#55 * dp_connectorimpl: Remove duplicate dscBitsPerPixelIncrement All other values of the BITS_PER_PIXEL_INCREMENT are handled here. This one was previously using a bitwise OR in, then also assigning directly after. Closes: NVIDIA#54 * dp_connectorimpl: Use switch-case for dscBitsPerPixelIncrement This is an enum, so we can just use a switch case instead of chaning IFs constantly. * 515.65.01 * 515.76 * 520.61.05 * 520.56.06 * 525.53 Co-authored-by: astolfo <[email protected]> Co-authored-by: Maneet Singh <[email protected]> Co-authored-by: Filip Fedoryszyn <[email protected]> Co-authored-by: TrickyDmitriy <[email protected]> Co-authored-by: keroeslux <[email protected]> Co-authored-by: Andy Ritger <[email protected]> Co-authored-by: Bernhard Stoeckner <[email protected]> Co-authored-by: Alcaparra <[email protected]> Co-authored-by: nitepone <[email protected]> Co-authored-by: Joshua Ashton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub announced issue forms a while ago. Issue forms are essentially forms you have to fill out, as opposed to the current Markdown section. It is much easier to use issue forms, looks prettier and some sections may even hard require for user input.
If you want to see it in action, don't hesitate to file issues! https://github.com/TheEvilSkeleton/open-gpu-kernel-modules/issues/new/choose