add unit test to replicate error nvidia device rename #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tariq Ibrahim <[email protected]>
tariq1890
force-pushed
the
nv-device-rename-test
branch
from
0da9d7d
to
f3e733f
Compare
elezar
reviewed
Feb 5, 2024
There was a problem hiding this comment.
I would recommend adding the tests as part of #330 instead. With the workflow (in theory) being:
- Add a test that fails for a
/proc/devicesfile with contents matching the 550 driver. - Make the changes to support the rename of
nvidia-frontendtonvidia - Ensure that the test passed.
Note that this also assumes that there's already a test in place for a /proc/devices file that contains nvidia-frontend and that this continues to work.
|
CLosing this as the tests were added as part of #330. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a unit test case to replicate the nvidia-ctk failing to create device nodes when on gpu drivers with versions >=
550.40.x