Barebones workflow to trigger pre-commit github action #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarmak-nv
requested changes
Sep 9, 2024
.github/workflows/pre-commit.yml
Outdated
| steps: | ||
| - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event." | ||
| - run: echo "🐧 This job is now running on a ${{ runner.os }} server hosted by GitHub!" | ||
| - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}." |
There was a problem hiding this comment.
We should remove this line; it's vulnerable to script injection if someone opens a PR and names their repo in a malicious manner.
(I selected the wrong part - sorry! I mean L14 since it echos the repo name, but tbh we probably should just remove them all.)
There was a problem hiding this comment.
(Any user modifiable field is at risk of this, repo is probably the least likely but still something we shouldn't open ourselves to.)
There was a problem hiding this comment.
Agreed. Honestly I just copied this example from a silly little boilerplate example in their docs. I'll make some meaningful changes here shortly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Barebones Github Action configuration to install and run
pre-commiton the nv-ingest codebaseThis closes: #63
Checklist