Add documentation to examples #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 1, 2023
mnabian
added
documentation
…dulus-launch into enh-ext-documentation
mnabian
added
3 - Ready for Review
|
/blossom-ci |
ktangsali
reviewed
Aug 2, 2023
ktangsali
reviewed
Aug 2, 2023
ktangsali
reviewed
Aug 2, 2023
|
Based on today's discussion, should the target branch be the rc branch and not |
|
Yeah, merging to RC branch would be to get this documentation in the tagged commit. Not the biggest deal but I suppose this would be nice. |
|
/blossom-ci |
mnabian
removed
the
4 - Needs Modulus Reviewer
examples/weather/graphcast/README.md
Outdated
| # GraphCast for weather forecasting | ||
|
|
||
| This example is a lightweight implementation of the DeepMind's | ||
| [GraphCast](https://arxiv.org/abs/2212.12794) model in PyTorch. |
There was a problem hiding this comment.
Add the why - to provide a recipe on how to train such GNN models in Modulus.
|
Looks good to me! |
ktangsali
approved these changes
Aug 4, 2023
NickGeneva
pushed a commit
to NickGeneva/modulus-launch
that referenced
this pull request
Aug 10, 2023
* add Ahmed body documentation * fix spelling * update wand instructions * adding vortex shedding doc * AFNO documentation * minor edits * afno getting started * first attempt to document SFNO * graphcast documentation * minor change * address review comments * address more review comments * Update AFNO doc * Update SFNO doc * Update GraphCast doc
NickGeneva
pushed a commit
to NickGeneva/modulus-launch
that referenced
this pull request
Aug 10, 2023
* add Ahmed body documentation * fix spelling * update wand instructions * adding vortex shedding doc * AFNO documentation * minor edits * afno getting started * first attempt to document SFNO * graphcast documentation * minor change * address review comments * address more review comments * Update AFNO doc * Update SFNO doc * Update GraphCast doc
NickGeneva
pushed a commit
that referenced
this pull request
Aug 10, 2023
* add Ahmed body documentation * fix spelling * update wand instructions * adding vortex shedding doc * AFNO documentation * minor edits * afno getting started * first attempt to document SFNO * graphcast documentation * minor change * address review comments * address more review comments * Update AFNO doc * Update SFNO doc * Update GraphCast doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modulus Pull Request
Description
Checklist
up to date with these changes.
Dependencies