Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Pip wheel and Dockerfile #127

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

ktangsali
Copy link
Collaborator

Modulus Pull Request

Description

This PR deprecates the launch pip wheel. The utils are up-streamed to the main modulus project and the source from this repo will be removed in the following release.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is
    up to date with these changes.

Dependencies

@ktangsali ktangsali requested a review from NickGeneva November 7, 2023 03:34
@ktangsali ktangsali self-assigned this Nov 7, 2023
@ktangsali ktangsali added 3 - Ready for Review Ready for review by team ! - Release PRs or Issues releating to a release labels Nov 7, 2023
@ktangsali ktangsali changed the base branch from main to 0.4.0-rc November 7, 2023 03:37
@ktangsali ktangsali changed the title Deprecate Pip wheel Deprecate Pip wheel and Dockerfile Nov 7, 2023
@ktangsali
Copy link
Collaborator Author

/blossom-ci

1 similar comment
@ktangsali
Copy link
Collaborator Author

/blossom-ci

@ktangsali ktangsali merged commit a63bcdc into NVIDIA:0.4.0-rc Nov 8, 2023
mariusaurus pushed a commit to mariusaurus/modulus-launch that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team ! - Release PRs or Issues releating to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants