This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Update broken_constant_eval.pass.cpp #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can fix #41 However, I don't know if there is a way to more specifically target a minor gcc version.
griwes
approved these changes
Oct 7, 2020
| @@ -11,7 +11,7 @@ | |||
| // UNSUPPORTED: windows, icc, pgi | |||
| // XFAIL: clang-9 && c++11 | |||
| // XFAIL: clang-10 && c++11 | |||
| // XFAIL: gcc-9 && c++11 | |||
| // gcc 10.0 is expected to pass, but later versions do not. | |||
There was a problem hiding this comment.
Is this meant to say GCC 9?
There was a problem hiding this comment.
See the list in the issue. I might have an inverted sense of what counts as passing because it's an expected failure.
Regardless, 10.0 is not susceptible while 10.1 and 10.2 are.
There was a problem hiding this comment.
I see. 10.0 is not a released version, so to avoid confusion we should probably not refer to it.
There was a problem hiding this comment.
Yeah, the basepoint was just tested to see if I could find exactly when NVCC picked this up. I'll run a full test suite today and commit by afternoon.
Do you want me to edit the comment for clarity?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can fix #41
However, I don't know if there is a way to more specifically target a minor gcc version.