This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Concepts reloaded #349
Merged
Concepts reloaded #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
force-pushed
the
concepts_reloaded
branch
6 times, most recently
from
6c443bf to
342ae82
Compare
miscco
force-pushed
the
concepts_reloaded
branch
2 times, most recently
from
740e7e1 to
45b2149
Compare
wmaxey
reviewed
Feb 14, 2023
wmaxey
reviewed
Feb 14, 2023
This also ports all the standard concepts from libc++ preserving the new modular organization.
The latter is defined by MSVC so it would clash
There is a long standing bug where MSVC incorrectly determines the result of `__is_constructible` when given cv-qualified types Furthermore, `common_reference` is broken similarly. This has been worked around in the MSVC standard library, so just port that fix from microsoft/STL#2592
There is something to say to enable those tests that work and only mark those that dont as unsupported, but this blanket statement seems better and makes the intent clear
miscco
force-pushed
the
concepts_reloaded
branch
from
deca19e to
8d5cdfc
Compare
Co-authored-by: Wesley Maxey <[email protected]>
wmaxey
approved these changes
Feb 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems I forgot to actually target main instead pf the now stale
modularize iterator branch🤦♂️