This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Use escape hook for removal of <ciso646> #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<ciso646> has been removed in C++20, which breaks the build against MSVC. Fortunately, there is an escape hatch that we can use to silence the deprecation warning and buy us some time until we settle on a better solution
wmaxey
approved these changes
Sep 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
has been removed in C++20, which in the future might break the build against MSVC.
Fortunately, there is an escape hatch that we can use to silence the deprecation warning and buy us some time until we settle on a better solution