-
Notifications
You must be signed in to change notification settings - Fork 187
Conversation
@griwes I completed everything I planned for this PR. The
I know very little about NVRTC, so I don't know how to resolve this. I suspect it is choking on some dependent include file. |
It looks like NVRTC started looking through system includes. I'm not sure where |
@griwes can you re-review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Jake, can we rename samples to examples, to match the style in Thrust/CUB?
This also means the top-level README.md in the repo (which is really a symlink to docs/readme.md) will need to update its link.
Also, can you change the extension on the files to .cu
? This helps with syntax highlighting, etc.
Also I added the concurrent hash table example.
You want the host only examples to be |
I'm good with the nature of these changes. I don't have any additional changes to request. |
@brycelelbach I add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
benchmarks/
to hold libcu++ benchmarksbenchmark.cu/.cpp
fromsamples/
tobenchmarks
(renamed toconcurrency_host/device
, but this can be changed)samples/
to build the existing samples