Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Revamp samples and benchmarks #31

Merged
merged 29 commits into from
Oct 29, 2020
Merged

Conversation

jrhemstad
Copy link
Collaborator

@jrhemstad jrhemstad commented Sep 30, 2020

  • Created benchmarks/ to hold libcu++ benchmarks
  • Moved benchmark.cu/.cpp from samples/ to benchmarks (renamed to concurrency_host/device, but this can be changed)
  • Overhauled the old CMakeList.txt for building the benchmarks to use more modern cmake
  • Add CMakeList.txt to samples/ to build the existing samples

@wmaxey wmaxey requested a review from griwes September 30, 2020 20:47
@jrhemstad jrhemstad marked this pull request as ready for review October 1, 2020 19:16
@jrhemstad
Copy link
Collaborator Author

@griwes I completed everything I planned for this PR. The rtc_example is compiling, but I can't get it to actually run. It fails at runtime with the error:

/usr/include/features.h(367): catastrophic error: cannot open source file "sys/cdefs.h"

1 catastrophic error detected in the compilation of "trie.cu".

I know very little about NVRTC, so I don't know how to resolve this. I suspect it is choking on some dependent include file.

@wmaxey
Copy link
Member

wmaxey commented Oct 1, 2020

@griwes I completed everything I planned for this PR. The rtc_example is compiling, but I can't get it to actually run. It fails at runtime with the error:

/usr/include/features.h(367): catastrophic error: cannot open source file "sys/cdefs.h"

1 catastrophic error detected in the compilation of "trie.cu".

I know very little about NVRTC, so I don't know how to resolve this. I suspect it is choking on some dependent include file.

It looks like NVRTC started looking through system includes. I'm not sure where /usr/include/features would have been included.

samples/rtc_example.cpp Outdated Show resolved Hide resolved
samples/rtc_example.cpp Show resolved Hide resolved
@jrhemstad
Copy link
Collaborator Author

@griwes @wmaxey resolved the nvrtc issue. Seemed to be a problem of just using CUDA 10.2. I updated the Cmake to only build the rtc example if the CUDA version is >10.2.

This should be good to go now.

@jrhemstad
Copy link
Collaborator Author

@griwes can you re-review?

Copy link
Collaborator

@brycelelbach brycelelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jake, can we rename samples to examples, to match the style in Thrust/CUB?

This also means the top-level README.md in the repo (which is really a symlink to docs/readme.md) will need to update its link.

Also, can you change the extension on the files to .cu? This helps with syntax highlighting, etc.

Also I added the concurrent hash table example.

@jrhemstad
Copy link
Collaborator Author

Also, can you change the extension on the files to .cu? This helps with syntax highlighting, etc.

You want the host only examples to be .cu?

@ogiroux
Copy link
Contributor

ogiroux commented Oct 19, 2020

I'm good with the nature of these changes. I don't have any additional changes to request.

@jrhemstad
Copy link
Collaborator Author

@brycelelbach I add the concurrent_hash_table.cu to the CMakeLists.txt and renamed samples -> examples.

Copy link
Collaborator

@griwes griwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brycelelbach brycelelbach added this to the 1.4.0 milestone Oct 29, 2020
@brycelelbach brycelelbach merged commit ba03506 into NVIDIA:main Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants