This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Move the emission of atomic errors on unsupported platforms to <atomic> #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@allisonvacanti Would you be able to see if this works for the virtuals you had linked? I can provide a P4 CL. |
|
Thanks @wmaxey! I'll just apply this locally as part of my virtual, since it's a fairly simple one. I'll let you know how it goes or if I find any other blockers. |
alliepiper
approved these changes
Aug 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
#errorfor unsupported threading platforms to a header where it is relevant.This allows
<type_traits>or other headers to actually have a chance at compiling.