This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Add documentation for atomic_ref #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griwes
suggested changes
Apr 25, 2022
There was a problem hiding this comment.
This is missing a very important thing: nowhere in here do we say whether it is legal or not for multiple atomic_ref objects of different scopes pointing to the same object to exist at the same time. We must be explicit on this, and I believe that we must forbid this, in case our handling of padding bits becomes "we zero them in a constructor of atomic_ref" (since that needs to occur atomically).
wmaxey
force-pushed
the
docs/atomic_ref
branch
2 times, most recently
from
f72e6c2 to
9487989
Compare
gonzalobg
reviewed
Oct 6, 2022
Co-authored-by: gonzalobg <[email protected]>
daniellustig
reviewed
Oct 7, 2022
daniellustig
reviewed
Oct 7, 2022
jrhemstad
reviewed
Oct 7, 2022
Co-authored-by: Jake Hemstad <[email protected]>
…ics. Co-authored-by: gonzalobg <[email protected]>
wmaxey
commented
Nov 29, 2022
wmaxey
commented
Nov 29, 2022
wmaxey
commented
Nov 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.