Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Draft: Revert/barrier parity #192

Closed
wants to merge 44 commits into from
Closed

Draft: Revert/barrier parity #192

wants to merge 44 commits into from

Conversation

wmaxey
Copy link
Member

@wmaxey wmaxey commented Aug 4, 2021

wait_parity and try_wait_parity has insufficient PLC and sign-off as an extension to the barrier API.

ogiroux and others added 30 commits August 4, 2021 11:44
@ogiroux @wmaxey
Added parity waiting
d39dda7
@ogiroux @wmaxey
Added try_wait options
a479b85
@wmaxey
Add a small parity wait test
b089ac2
@wmaxey
Extend the test to measure both phases, make barrier_(try_)wait_parit…
a424765 
…y member functions
@wmaxey
Re-add the __try_wait API as pipeline uses internal symbols of barrie…
0560b71 
…r for some reason
@wmaxey
Remove all uses of non-compliant __CUDA_ARCH__/preprocessor macros fr…
318c275 
…om libcudacxx
@wmaxey
Fix an issue in NVRTC tests
0179859
@wmaxey
Move files and implementation for atomic refactor
b457a75
@wmaxey
WIP: single interface wrap/unwrap
ae8a1e2
@wmaxey
Finish atomic refactor, bones of atomic_ref are in place
d6d0812
@wmaxey
Refactor a few #ifdef __CUDA__ things and fix statics/shared memory u…
ed349b7 
…sage in tests
@wmaxey
Implement CUDA atomic ref, implement MSVC atomics layer, fix several …
e04d828 
…test utilities
@wmaxey
Fix atomic_mscv header, fix macro processing in __threading_support o…
8cedc23 
…n MSVC, fix a test that used preprocessor directives within NV_TARGET
@wmaxey
Fix some local errors and warnings, put back the SHARED macro, fix pi…
f6145ca 
…peline tests
@wmaxey
Add symlink to nv/target within libcxx
bed0287
@wmaxey
Fix CV handling of atomics on the libcxx/std layer
0072881
@wmaxey
Disable C11 atomics in __config
a1328d7
@wmaxey
fixups for Clang specific issues in atomic, make sure <nv/target> is …
1360f48 
…within a C++ context
@wmaxey
Fix CUDA and MSVC atomic layers
5363202
@wmaxey
uncomment a couple tests from pipeline
c7d913f
@wmaxey
Revert tests, will <nv/target>-ify later
2da7c63
@wmaxey
Rebuild atomic_cuda_generated
79ceb8b
@wmaxey
Dedup MSVC by splitting the atomic base class into a seperate header …
6d0d094 
…and creating back-end intrinsics in the MSVC header
@wmaxey
Missed grabbing important parts of the nvcxx-compatibility branch whe…
be9bacc 
…n cherry-picking
@wmaxey
Pickup more nv/target specializations from nvcxx_compatibility branch
03641c9
@wmaxey
Uglify the atomic detail:: and host:: namespaces
1b64243
@wmaxey
Rename __skip_amt to __atomic_ptr_inc
0d31a92
@wmaxey
Refactor and dedup some code in the __cxx_atomic cuda layer, fix runt…
28a7a2f 
…ime lock free check
@wmaxey
Fix set-but-not-used warnings for atomic intrinsics in atomic_base.h
4060036
@wmaxey
Fix static_assert in bad_atomic_alignment test.
239151f
wmaxey and others added 13 commits August 4, 2021 11:44
@wmaxey
Suppress pointless comparison warnings where tests are impacted by th…
7db3ff2 
…e introduction of <nv/target>
@wmaxey
Add a missing license header to the atomic_c11.h file
b219567
@wmaxey
Fix pointless comparison warnings on two other pipeline tests
1e57f8a
@wmaxey
Wrap/Unwrap store, exchange, and load to make sure the 'written to' p…
65ab07b 
…arts of atomics are aligned
@wmaxey
Change method of ensuring that atomic types match
560a8c6
@wmaxey
Fix spurious warnings in atomic_base.h
572c286
@wmaxey
Rename __to_gcc_order to __cxx_atomic_order_to_int
c0c861f
@wmaxey
Reset barrier/latch/semaphore to head, as those will be nv/target'd l…
c9e07dc 
…ater
@wmaxey
Fix a few includes occuring within internal namespaces
917101a
@wmaxey
Create changelog for release 1.6.0
1d1b6bb
@wmaxey
Bump libcudacxx API version to 1.6.0
5385867
@wmaxey
Add clearer notification about ABI break. Fix capitalization.
8ff18aa
@wmaxey
Revert "Re-add the __try_wait API as pipeline uses internal symbols o…
25e386c 
…f barrier for some reason"

This reverts commit f882b5d.

Revert "Extend the test to measure both phases, make barrier_(try_)wait_parity member functions"

This reverts commit bc80e36.

Revert "Add a small parity wait test"

This reverts commit 1464783.

Revert "Added try_wait options"

This reverts commit 6e72dc6.

Revert "Added parity waiting"

This reverts commit 69e7f77.
@wmaxey wmaxey requested review from brycelelbach and ogiroux August 4, 2021 18:48
@wmaxey wmaxey changed the title Revert/barrier parity Draft: Revert/barrier parity Aug 4, 2021
@wmaxey wmaxey marked this pull request as draft August 4, 2021 18:50
@brycelelbach
Copy link
Collaborator

This seems extreme and unnecessary. Instead let's just have Olivier write up a design doc for it.

brycelelbach
brycelelbach suggested changes Aug 5, 2021
View reviewed changes
Copy link
Collaborator

@brycelelbach brycelelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't yanking this; just provide the requested design docs.

@wmaxey
Copy link
Member Author

wmaxey commented Aug 5, 2021

We aren't yanking this; just provide the requested design docs.

#111 has updated PLC documentation.

@wmaxey wmaxey closed this Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brycelelbach brycelelbach brycelelbach requested changes

@ogiroux ogiroux Awaiting requested review from ogiroux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wmaxey @brycelelbach @ogiroux