This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Bugfix/abi breaking changes #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 8, 2021
wmaxey
force-pushed
the
bugfix/abi_breaking_changes
branch
from
5c039ba to
6d85fc0
Compare
wmaxey
force-pushed
the
bugfix/abi_breaking_changes
branch
from
6d85fc0 to
050663e
Compare
griwes
approved these changes
Jul 29, 2021
libcxx/include/chrono
Outdated
Comment on lines
3240
to
3242
| constexpr chrono::duration<double> operator""s(long double __s) | ||
| { | ||
| return chrono::duration<long double> (__s); | ||
| return chrono::duration<double> (__s); |
There was a problem hiding this comment.
Should be _LIBCUDACXX_CHRONO_LITERAL_INTERNAL_T too, not double.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've merged #165 and #161 as these are the ABI breaking changes we're aiming to get in this release.