guard against None in leakreplay attempt history management
#1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kreplay / attempt history
leondz
added
bug
jmartin-tech
approved these changes
Jan 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #879
NoneTypein attempt message history would cause a crash whenleakreplayrewrites that message history. Guard againstNonehere. It's unclear how a None would get in there in the first place, but the original report hasn't had updates, so this may have been a transient behaviour.Thanks @bleszily
Verification
python -m pytest tests/probes/test_probes_leakreplay.py::test_leakreplay_handle_incomplete_attempt