Bump rapids-cmake version #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
topic: build
sleeepyjack
approved these changes
Jun 8, 2024
|
Just realized the CCCL2.5 PR merged earlier today, let me rerun the CI to make sure. |
|
It seems like most of the errors originate from |
/home/coder/cuCollections/build/amd64-gcc12-cuda12.4/_deps/cccl-src/libcudacxx/lib/cmake/libcudacxx/../../../include/cuda/std/__ranges/access.h(138): error: function "cuda::std::ranges::__4::__begin::__cxx17::__fn::operator()(_Tp &&) const [with _Tp=cuco::distinct_count_estimator_ref<int, cuda::std::__4::thread_scope_device, cuco::detail::XXHash_64<int>> &, _LIBCUDACXX_true_=true, <unnamed>=0, <unnamed>=0]" (declared at line 126) cannot be referenced -- it is a deleted function
239
using iterator_t = decltype(::cuda::std::ranges::__4::begin(::cuda::std::__4::declval<_Tp&>()));
240
^
241
detected during:
242
instantiation of type "cuda::std::ranges::__4::iterator_t<cuco::distinct_count_estimator_ref<int, cuda::std::__4::thread_scope_device, cuco::detail::XXHash_64<int>>>" at line 181 of /home/coder/cuCollections/build/amd64-gcc12-cuda12.4/_deps/cccl-src/libcudacxx/lib/cmake/libcudacxx/../../../include/cuda/std/__ranges/concepts.h
243
instantiation of type "cuda::std::ranges::__4::range_reference_t<cuco::distinct_count_estimator_ref<int, cuda::std::__4::thread_scope_device, cuco::detail::XXHash_64<int>>>" at line 212 of /home/coder/cuCollections/build/amd64-gcc12-cuda12.4/_deps/cccl-src/libcudacxx/lib/cmake/libcudacxx/../../../include/cuda/std/detail/libcxx/include/span
244
instantiation of "const bool cuda::std::__4::__span_compatible_range [with _Range=cuco::distinct_count_estimator_ref<int, cuda::std::__4::thread_scope_device, cuco::detail::XXHash_64<int>>, _ElementType=std::byte]" at line 147 of /home/coder/cuCollections/examples/distinct_count_estimator/device_ref_example.cu
245I see ranges... WOW |
|
NVIDIA/cccl#1836 should fix the issue with span |
sleeepyjack
force-pushed
the
PointKernel-patch-1
branch
from
c92b848
to
693698d
Compare
12 tasks
sleeepyjack
force-pushed
the
PointKernel-patch-1
branch
from
76d77c9
to
693698d
Compare
|
Waiting for rapidsai/rapids-cmake#631 to get merged so we can use that version to get rid of the build errors. Once done, we can merge this PR and then bump the cuco version in `rapids-cmake' again to the HEAD of this branch. |
rapids-bot bot
pushed a commit
to rapidsai/rapids-cmake
that referenced
this pull request
Jun 24, 2024
This PR updates the CCCL version to include a fix for `cuda::std::span` which is required for cuCollections to work properly with CCCL 2.5.0. Most of the changes between the last CCCL version bump (#607) and this one were related to doc updates and unit test fixes, so I don't expect much functional impact for RAPIDS. After this PR we likely have to bump the cuco version again to include the new changes. ### CCCL PR: - NVIDIA/cccl#1836 ### CUCO PR: - NVIDIA/cuCollections#502 ### RAPIDS PRs: - [x] rapidsai/cudf#15986 - [error during docs-build](https://github.com/rapidsai/cudf/actions/runs/9406273871/job/25911619452?pr=15946#step:9:2243) but seems unrelated - [x] rapidsai/cugraph#4483 - some CI jobs ran into a network timeout -> rerunning - [x] rapidsai/cuml#5924 - successful apart from some optional conda python tests - [x] rapidsai/raft#2358 - This one is weird as it [shows an error](https://github.com/rapidsai/raft/actions/runs/9475150045/job/26109283214?pr=2358#step:7:824) that is similar to the one we found in cuco when bumping the CCCL version to 2.5.0. However, we thought the problem was on cuco's end and pushed a fix that resolved the issue (see [Slack thread](https://nvidia.slack.com/archives/CCP05T27R/p1718060955876199)) - [x] rapidsai/rmm#1584 Authors: - Daniel Jünger (https://github.com/sleeepyjack) Approvers: - Bradley Dice (https://github.com/bdice) URL: #631
|
Looks good. Ship it! 🛳️⛴️🚢 |
sleeepyjack
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rapids-cmake version to 24.08