Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data structure base classes and cuco::static_set #278

Merged
merged 236 commits into from
Apr 6, 2023
Merged

Add data structure base classes and cuco::static_set #278

merged 236 commits into from
Apr 6, 2023

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Mar 6, 2023 •
edited
Loading

This is the first PR related to #110.

It introduces the concept of:

  • New probing scheme which incorporates a probing iterator
  • Array of windows storage instead of flat storage to better deal with memory bandwidth-bound workload when hash collision is high
  • Dynamic and static extent type for efficient probing
  • Mixin to encode concurrent device operators
  • Synchronous and asynchronous host bulk APIs

This PR also adds cuco::static_set to evaluate the new design. For now, only 2 basic operations, insert and contains are supported.

@PointKernel
Add storage class
d4a4a48
@PointKernel
Add static_set class
2afb416
@PointKernel
Update static_set class
8413375
@PointKernel
Update static_set & storage classes
0ee3dbb
@PointKernel
Use value_type instead of deprecated pointer
1d86b04
@PointKernel
Add utility unit test
eb23f76
@PointKernel
Merge remote-tracking branch 'upstream/dev' into grand-refactor
108893b
@PointKernel
Add a file for common kernels
f796e9c
@PointKernel
Add AOS storage view
a9b7106
@PointKernel
Add experimental probing scheme
29a91b4
@PointKernel
Add first static_set test
1187046
@PointKernel
Merge remote-tracking branch 'upstream/dev' into grand-refactor
dffe113
@PointKernel
Add static_set_ref
b6aa668
@PointKernel
Use probing iterator logic
0c11e98
@PointKernel
Add extent class
fdc3db1
@PointKernel
Use extent instead of naive size type
fb35c3b
@PointKernel
Minor cleanup
a858574
@PointKernel
Update probing scheme to incorporate template size type
2f0b69a
@PointKernel
Merge remote-tracking branch 'upstream/dev' into grand-refactor
1c230f5
@PointKernel
Include cuda std array header
b2459f7
@PointKernel
Merge remote-tracking branch 'upstream/dev' into grand-refactor
45441a3
@PointKernel
Fix a bug: pass template parameter when return probing iterator
ba5c609
@PointKernel
Move new implementations to experimental namespace
ff704c2
@PointKernel
Add equality wrapper
1637cff
@PointKernel
Add simple insert
7cd8a0d
@PointKernel
Doc cleanups
79d669d
@PointKernel
Pass scope to device ref
fd74ede
@PointKernel
Fix postfix increment overloading
1e500a7
@PointKernel
Minor cleanups
2f5089c
@PointKernel
Use size_type + fix a bug in double hashing
d19f374
sleeepyjack
sleeepyjack reviewed Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@sleeepyjack sleeepyjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second to last batch. I promise.

include/cuco/detail/storage/counter_storage.cuh Show resolved Hide resolved
include/cuco/detail/storage/counter_storage.cuh Show resolved Hide resolved
include/cuco/detail/storage/storage_base.cuh Outdated Show resolved Hide resolved
include/cuco/extent.cuh Show resolved Hide resolved
include/cuco/static_set.cuh Outdated Show resolved Hide resolved
include/cuco/static_set.cuh Outdated Show resolved Hide resolved
include/cuco/static_set.cuh Outdated Show resolved Hide resolved
include/cuco/static_set.cuh Outdated Show resolved Hide resolved
sleeepyjack
sleeepyjack reviewed Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@sleeepyjack sleeepyjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last one 🎉

include/cuco/static_set_ref.cuh Outdated Show resolved Hide resolved
include/cuco/static_set_ref.cuh Outdated Show resolved Hide resolved
include/cuco/static_set_ref.cuh Outdated Show resolved Hide resolved
include/cuco/static_set_ref.cuh Outdated Show resolved Hide resolved
include/cuco/static_set_ref.cuh Outdated Show resolved Hide resolved
include/cuco/static_set_ref.cuh Outdated Show resolved Hide resolved
sleeepyjack
sleeepyjack approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@sleeepyjack sleeepyjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀 🚀

sleeepyjack
sleeepyjack reviewed Apr 5, 2023
View reviewed changes
include/cuco/static_set.cuh Show resolved Hide resolved
include/cuco/static_set.cuh Outdated Show resolved Hide resolved
include/cuco/static_set.cuh Show resolved Hide resolved
include/cuco/static_set.cuh Outdated Show resolved Hide resolved
@PointKernel PointKernel merged commit ed620ab into dev Apr 6, 2023
@PointKernel PointKernel deleted the refactor branch April 6, 2023 00:46
@PointKernel PointKernel added the topic: static_set Issue related to the static_set label Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleeepyjack sleeepyjack sleeepyjack approved these changes

@jrhemstad jrhemstad Awaiting requested review from jrhemstad

Assignees
No one assigned
Labels
helps: rapids Helps or needed by RAPIDS Needs Review Awaiting reviews before merging topic: static_set Issue related to the static_set type: feature request New feature request
Projects
CCCL
Archived in project
Milestone
Refactor Open Address Data Structures
Development

Successfully merging this pull request may close these issues.
2 participants
@PointKernel @sleeepyjack