[Bug] Fix a bug in fused rope #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Yao <[email protected]>
crcrpar
approved these changes
Nov 16, 2023
StellaAthena
added a commit
to EleutherAI/gpt-neox
that referenced
this pull request
Nov 25, 2023
Ports the fix from NVIDIA/apex#1750 into this branch.
Quentin-Anthony
added a commit
to EleutherAI/gpt-neox
that referenced
this pull request
Jan 5, 2024
* Create fused_rotary_positional_embedding.cpp * Create fused_rotary_positional_embedding.h * Create fused_rotary_positional_embedding_cuda.cu * Update fused_rotary_positional_embedding.h Ports the fix from NVIDIA/apex#1750 into this branch. * Update neox_args.py * Update setup.py * Update initialize.py * Update setup.py * Update __init__.py * Update test_fused_kernels.py * Update setup.py * Create fused_rope.py * Update fused_rotary_positional_embedding.h * Update fused_rotary_positional_embedding.cpp * Update fused_rotary_positional_embedding.cpp * Update transformer.py * Update transformer.py Just checked and this should work for bf16. Or, at least, the reason I originally thought it wouldn't doesn't apply. * Update transformer.py * Create 125M_fused_rope.yml * Update 125M_fused_rope.yml * Update transformer.py Add `self.rope_fusion = neox_args.rope_fusion` so that `ParallelSelfAttention` knows if we're using rope fusion. * Update NeoXArgs docs automatically * Update NeoXArgs docs automatically * Fix fused rope Just needed to bring in the latest headers/sources, and call into it the right way from transformers.py. * Add rope_fusion arg to all ymls --------- Co-authored-by: Stella Biderman <[email protected]> Co-authored-by: github-actions <[email protected]> Co-authored-by: Quentin Anthony <[email protected]> Co-authored-by: Yang Zhang <[email protected]>
caaatch22
pushed a commit
to caaatch22/apex
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Xin Yao <[email protected]>
SkyHeroesS
pushed a commit
to SkyHeroesS/beforeholiday
that referenced
this pull request
Dec 20, 2024
Signed-off-by: Xin Yao <[email protected]>
caaatch22
pushed a commit
to caaatch22/apex
that referenced
this pull request
Dec 23, 2024
Signed-off-by: Xin Yao <[email protected]>
caaatch22
pushed a commit
to caaatch22/apex
that referenced
this pull request
Dec 23, 2024
Signed-off-by: Xin Yao <[email protected]>
caaatch22
pushed a commit
to caaatch22/apex
that referenced
this pull request
Dec 23, 2024
Signed-off-by: Xin Yao <[email protected]>
caaatch22
pushed a commit
to caaatch22/apex
that referenced
this pull request
Dec 23, 2024
Signed-off-by: Xin Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in the fused rope backward calculation. cc @crcrpar