Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JAX] Skip V100 encoder tests #1262

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[JAX] Skip V100 encoder tests #1262

wants to merge 2 commits into from
+27 −0

Conversation

zlsh80826
Copy link
Collaborator

Description

V100 doesn't have BF16 hardware support, this PR is to skip the V100 failing tests with BF16 data type.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

  • Skip all encoder tests if the CC < 80

  • I have read and followed the contributing guidelines

  • The functionality is complete

  • I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation

  • My changes generate no new warnings

  • I have added tests that prove my fix is effective or that my feature works

  • New and existing unit tests pass locally with my changes

@zlsh80826
Skip encoder tests on V100
cf04939 
Signed-off-by: Reese Wang <[email protected]>
@zlsh80826 zlsh80826 force-pushed the rewang/skip-v100-encoder-tests branch from bd49e48 to cf04939 Compare October 16, 2024 12:42
@zlsh80826
Copy link
Collaborator Author

/te-ci jax

@zlsh80826
Add copyright
2e00814 
Signed-off-by: Reese Wang <[email protected]>
ksivaman
ksivaman approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksivaman
Copy link
Member

/te-ci jax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phu0ngng phu0ngng phu0ngng approved these changes

@ksivaman ksivaman ksivaman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zlsh80826 @ksivaman @phu0ngng