don't violate strict aliasing with reinterpret_cast #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there are some plugins which have the same problem (functions are |
rajeevsrao
reviewed
Oct 16, 2019
plugin/common/plugin.h
Outdated
| @@ -57,15 +58,16 @@ class BaseCreator : public IPluginCreator | |||
| template <typename T> | |||
| void write(char*& buffer, const T& val) | |||
| { | |||
| *reinterpret_cast<T*>(buffer) = val; | |||
| std::memcpy(buffer, &t, sizeof(T)); | |||
There was a problem hiding this comment.
absolutely! I'm away from a machine with an nvidia graphics card for some time, so I'll have to wait to verify everything (but I'll make this change for sure)
| @@ -579,14 +579,15 @@ class UffPoolPluginV2 : public IPluginV2IOExt | |||
| template <typename T> | |||
| void write(char*& buffer, const T& val) const | |||
| { | |||
| *reinterpret_cast<T*>(buffer) = val; | |||
| std::memcpy(buffer, &t, sizeof(T)); | |||
Signed-off-by: Tom Peters <[email protected]>
tdp2110
force-pushed
the
tom/strict-aliasing
branch
from
5db69fc
to
8339fbb
Compare
rajeevsrao
approved these changes
Nov 6, 2019
kevinch-nv
approved these changes
Sep 9, 2020
|
@tdp2110 can you please incorporate the review changes? Thanks. |
|
@rajeevsrao I believe it is incorporated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Peters [email protected]