Advanced DiT Training #11226
Closed
Advanced DiT Training #11226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanhe42
previously approved these changes
Nov 8, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -19,24 +19,31 @@ | |||
| import torch | |||
| from megatron.core.distributed import DistributedDataParallelConfig | |||
| from megatron.core.optimizer import OptimizerConfig | |||
| from megatron.core.transformer.enums import AttnMaskType | |||
Check notice
Code scanning / CodeQL
Unused import
Comment on lines
+471
to
+546
| torch.cuda.memory._record_memory_history( | ||
| True, | ||
| # Keep 100,000 alloc/free events from before the snapshot | ||
| trace_alloc_max_entries=100000, | ||
| # Record stack information for the trace events | ||
| trace_alloc_record_context=True, | ||
| ) |
Check warning
Code scanning / CodeQL
Unreachable code
ethanhe42
previously approved these changes
Nov 8, 2024
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Thank you for improving NeMo's documentation! |
|
beep boop 🤖: 🚨 The following files must be fixed before merge! Your code was analyzed with PyLint. The following annotations have been identified: Thank you for improving NeMo's documentation! |
zpx01
force-pushed
the
zpx01/dit_advanced_training
branch
from
1b3dae5
to
654b7b6
Compare
zpx01
force-pushed
the
zpx01/dit_advanced_training
branch
from
654b7b6
to
f3fc7ea
Compare
Signed-off-by: Zeeshan Patel <[email protected]> packed sequence support Signed-off-by: Zeeshan Patel <[email protected]> fixed pylint issues Signed-off-by: Zeeshan Patel <[email protected]> add docstrings + remove unused import Signed-off-by: Zeeshan Patel <[email protected]> Apply isort and black reformatting Signed-off-by: zpx01 <[email protected]> Signed-off-by: Zeeshan Patel <[email protected]> added some missing args Signed-off-by: Zeeshan Patel <[email protected]> reformat Signed-off-by: Zeeshan Patel <[email protected]> moving fps embedder to gpu Signed-off-by: Zeeshan Patel <[email protected]> moving fps tensor to gpu Signed-off-by: Zeeshan Patel <[email protected]> updated models Signed-off-by: Zeeshan Patel <[email protected]> added missing import Signed-off-by: Zeeshan Patel <[email protected]> added new configs + bug fixes Signed-off-by: Zeeshan Patel <[email protected]> seq len fix Signed-off-by: Zeeshan Patel <[email protected]> Apply isort and black reformatting Signed-off-by: zpx01 <[email protected]> Signed-off-by: Zeeshan Patel <[email protected]> added nsys callback Signed-off-by: Zeeshan Patel <[email protected]> Apply isort and black reformatting Signed-off-by: zpx01 <[email protected]> Signed-off-by: Zeeshan Patel <[email protected]> isort fix Signed-off-by: Zeeshan Patel <[email protected]>
zpx01
force-pushed
the
zpx01/dit_advanced_training
branch
from
f3fc7ea
to
3805601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds the following new features to the Diffusion Training Framework:
Collection: diffusion
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information