Remove redundant hasattr
check in nemoguardrails/llm/params.py
#93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python, the getattr function is used to dynamically retrieve the value of an attribute or to call a method of an object.
Here's the basic syntax of the getattr function:
object
: The object from which you want to retrieve the attribute.attribute_name
: A string representing the name of the attribute you want to access.default
: An optional value that will be returned if the attribute does not existSince we already have
If "model_kwargs" is not an attribute of
self.llm
, the boolean statement will reduce to:which will evaluate to false. Therefore, we don't need to check for
hasattr(self.llm, "model_kwargs")
separately.Thus, I have removed the
hasattr(...)
check that precedes theparam in getattr(...)
check.