Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: max_tokens is not used by all models. \\\\ #822

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

patrickreinan
Copy link

@patrickreinan patrickreinan commented Oct 24, 2024

There is a issue when using Amazon Bedrock

Description

When using Amazon Bedrock I was facing a issue with "max_tokens" kwargs. Amazon Bedrock does not support this argument.

Related Issue(s)

N/A

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

@Pouyanpi
Copy link
Collaborator

Hi @patrickalvesexperian , thank you for opening this PR. Would you please first open a bug issue and then link this PR there?

Thanks

@patrickreinan patrickreinan mentioned this pull request Oct 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants