Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/output parser validation #704

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Fix/output parser validation #704

merged 2 commits into from
Aug 29, 2024

Conversation

Pouyanpi
Copy link
Collaborator

This PR fixes a bug in the check_output_parser_exists method and its tests. The method was not handling TaskPrompt objects correctly, and the tests were not reflecting this functionality. The method and tests have been updated to correctly handle TaskPrompt objects.

@Pouyanpi Pouyanpi requested a review from drazvan August 27, 2024 13:05
@Pouyanpi Pouyanpi force-pushed the fix/output-parser-validation branch from 6a6daa2 to 6638c95 Compare August 27, 2024 13:07
Copy link
Collaborator

@drazvan drazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍.

@drazvan drazvan merged commit 9c741bd into develop Aug 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants