Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: pass config and kwargs to passthrough_fn runnable for issue 665 #695

Conversation

vpr1995
Copy link
Contributor

@vpr1995 vpr1995 commented Aug 23, 2024

fix: updated the code to pass config and kwargs to passthrough_fn

also wrapped synchronous runnable into asynchronous so that it stays consistent with all synchronous runnables

issue link

@vpr1995 vpr1995 changed the title Fix for issue 665 Fix: pass config and kwargs to passthrough_fn runnable for issue 665 Aug 23, 2024
@vpr1995 vpr1995 force-pushed the fix-issue-665-config-parameter-is-not-passed-in-runnable branch from 63c2f6f to 5f3dacd Compare August 23, 2024 06:43
@vpr1995
Copy link
Contributor Author

vpr1995 commented Aug 23, 2024

By wrapping the synchronous invoke in an async coroutine, I was able to run the runnables which only support synchronous implementation

@vpr1995 vpr1995 force-pushed the fix-issue-665-config-parameter-is-not-passed-in-runnable branch from 5f3dacd to d8b70fe Compare August 23, 2024 06:58
@drazvan
Copy link
Collaborator

drazvan commented Aug 23, 2024

Thanks @vpr1995! This looks good 👍 .
Can you also add a test for this? Something basic, to make sure we don't break this in the future.
Also, please make sure your commits are signed. Check out the contributing guidelines: https://github.com/NVIDIA/NeMo-Guardrails/blob/main/CONTRIBUTING.md#submitting-your-work.

@vpr1995 vpr1995 force-pushed the fix-issue-665-config-parameter-is-not-passed-in-runnable branch 2 times, most recently from 6799f8a to 11f73f6 Compare August 23, 2024 20:30
also wrapped synchronous runnable into asynchronous so that it stays consistent with all synchronous runnables
@vpr1995 vpr1995 force-pushed the fix-issue-665-config-parameter-is-not-passed-in-runnable branch from 11f73f6 to e44679e Compare August 23, 2024 20:54
@drazvan drazvan self-requested a review August 29, 2024 09:38
Copy link
Collaborator

@drazvan drazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drazvan drazvan merged commit 4f4595b into NVIDIA:develop Aug 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants