Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/output parser deprecation warning #691

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

Pouyanpi
Copy link
Collaborator

@Pouyanpi Pouyanpi commented Aug 22, 2024

  • Add a new root validator to the RailsConfig class to check if an output
    parser is registered for each task. If not, a deprecation warning is
    logged. This change is in preparation for a future version where
    registering the 'output_parser' in the prompts.yml for each task will
    be mandatory.

  • Remove the deprecation warnings related to output parser registration
    from the self_check_facts, self_check_input, and self_check_output
    actions. The warnings are now handled in the RailsConfig class.

Pending:

  • Add tests
  • double check the tasks_requiring_output_parser with @drazvan

@Pouyanpi Pouyanpi requested a review from drazvan August 22, 2024 10:51
@Pouyanpi Pouyanpi force-pushed the fix/output-parser-deprecation-warning branch from eccc29d to 2e68c57 Compare August 22, 2024 12:57
@Pouyanpi
Copy link
Collaborator Author

@drazvan we can add more tests to the test_rails_config.py in future, or shall I use a different name?

Add a new root validator to the RailsConfig class to check if an output
parser is registered for each task. If not, a deprecation warning is
logged. This change is in preparation for a future version where
registering the 'output_parser' in the prompts.yml for each task will
be mandatory.

change logging to info

remove comment
Remove the deprecation warnings related to output parser registration
from the self_check_facts, self_check_input, and self_check_output
actions. The warnings are now handled in the RailsConfig class.
@Pouyanpi Pouyanpi force-pushed the fix/output-parser-deprecation-warning branch from 83f69b3 to bd522cf Compare August 22, 2024 13:11
@drazvan drazvan merged commit 1e38fbf into develop Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants