Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select model type and custom prompts task.py #486

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

cyun9601
Copy link
Contributor

@cyun9601 cyun9601 commented May 8, 2024

Fixed an issue where the LLM model and custom prompts could not distinguish between main and other tasks.

Fixed an issue where the LLM model and custom prompts could not distinguish between main and other tasks.

Signed-off-by: changyun <[email protected]>
@cyun9601 cyun9601 changed the title Update prompts.py Fix select model type and custom prompts task.py May 8, 2024
Fixed an issue where the LLM model and custom prompts could not distinguish between main and other tasks.

Signed-off-by: changyun <[email protected]>
cyun9601 added a commit to cyun9601/NeMo-Guardrails that referenced this pull request May 8, 2024
If you make custom prompt work as per NVIDIA#486, you should write the output parser. 

Additionally, it seems that need to list all the items available as config for prompts in this user guide file.

Signed-off-by: changyun <[email protected]>
Signed-off-by: changyun <[email protected]>
@drazvan drazvan self-requested a review July 10, 2024 09:45
Copy link
Collaborator

@drazvan drazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @cyun9601! 👍

@drazvan drazvan merged commit 3b2540d into NVIDIA:develop Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants