Skip explicit comms shuffle for dask-cuda 24.06 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ayush Dattagupta <[email protected]>
ayushdg
changed the title
|
cc: @rjzamora |
rjzamora
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
The dask-cuda fix is in for 24.08, so this LGTM.
Have you confirmed that rapidsai/dask-cuda#1356 produces proper partitioning in Curator?
Not yet, we're finalizing the NeMo-Curator 0.4.0 branch shortly which will depend on 24.06 rapids packages. I'll followup in a seperate discussion with 24.08 testing |
sarahyurick
pushed a commit
to sarahyurick/NeMo-Curator
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Ayush Dattagupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dask-cuda 24.06 + explicit comms leads to incorrect results in some cases as mentioned in #134 and will be fixed via rapidsai/dask-cuda#1356.
This disables going via explicit comms shuffle with dask-cuda 24.06 to avoid potentially incorrect results.
Usage
N/A
Checklist