Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for running cpu pytests #13

Merged
merged 8 commits into from
Mar 21, 2024
Merged

Conversation

ayushdg
Copy link
Collaborator

@ayushdg ayushdg commented Mar 21, 2024

No description provided.

@ayushdg
Copy link
Collaborator Author

ayushdg commented Mar 21, 2024

@ryantwolf Looks like Nemo-toolkit install fails in a python 3.9 environment (can reproduce locally). I can skip 3.9 tests here for the time being, but not sure if it's supposed to work with 3.9 or not.

@ryantwolf
Copy link
Collaborator

ryantwolf commented Mar 21, 2024

@ayushdg hm, why does it fail with 3.9? I can ask around if it's supposed to work. I see the logs now. We can skip for now though.

After talking with folks, looks like NeMo only supports Python 3.10 and above now. So we should bump our minimum version too.

Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
@ayushdg ayushdg force-pushed the ayushdg/ci/add-pytest-action branch from 4c34630 to 2cdc937 Compare March 21, 2024 22:01
@ayushdg ayushdg marked this pull request as ready for review March 21, 2024 22:02
@ayushdg
Copy link
Collaborator Author

ayushdg commented Mar 21, 2024

After talking with folks, looks like NeMo only supports Python 3.10 and above now. So we should bump our minimum version too.

Thanks, I'll limit the scope of the PR to 3.10 testing. We can bump the minimum version in a followup.

@ayushdg ayushdg assigned ryantwolf and unassigned ryantwolf Mar 21, 2024
@ayushdg ayushdg requested a review from ryantwolf March 21, 2024 22:16
Copy link
Collaborator

@ryantwolf ryantwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@ryantwolf ryantwolf merged commit 2cd02f3 into main Mar 21, 2024
2 of 3 checks passed
@ryantwolf ryantwolf deleted the ayushdg/ci/add-pytest-action branch March 21, 2024 22:21
ayushdg added a commit that referenced this pull request Mar 21, 2024
* Add workflow for cpu pytests

Signed-off-by: Ayush Dattagupta <[email protected]>

* Install wheel to fix fasttext import

Signed-off-by: Ayush Dattagupta <[email protected]>

* Omit python 3.8, do not fast fail

Signed-off-by: Ayush Dattagupta <[email protected]>

* Check if updating setuptools/pip changes cython errors

Signed-off-by: Ayush Dattagupta <[email protected]>

* Explicitly install cython

Signed-off-by: Ayush Dattagupta <[email protected]>

* Try freeing up space before install

Signed-off-by: Ayush Dattagupta <[email protected]>

* Try rapids_no_initialize

Signed-off-by: Ayush Dattagupta <[email protected]>

* remove python 3.9 testing for now

Signed-off-by: Ayush Dattagupta <[email protected]>

---------

Signed-off-by: Ayush Dattagupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants