-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow for running cpu pytests #13
Conversation
@ryantwolf Looks like Nemo-toolkit install fails in a python 3.9 environment (can reproduce locally). I can skip 3.9 tests here for the time being, but not sure if it's supposed to work with 3.9 or not. |
@ayushdg After talking with folks, looks like NeMo only supports Python 3.10 and above now. So we should bump our minimum version too. |
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
4c34630
to
2cdc937
Compare
Thanks, I'll limit the scope of the PR to 3.10 testing. We can bump the minimum version in a followup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
* Add workflow for cpu pytests Signed-off-by: Ayush Dattagupta <[email protected]> * Install wheel to fix fasttext import Signed-off-by: Ayush Dattagupta <[email protected]> * Omit python 3.8, do not fast fail Signed-off-by: Ayush Dattagupta <[email protected]> * Check if updating setuptools/pip changes cython errors Signed-off-by: Ayush Dattagupta <[email protected]> * Explicitly install cython Signed-off-by: Ayush Dattagupta <[email protected]> * Try freeing up space before install Signed-off-by: Ayush Dattagupta <[email protected]> * Try rapids_no_initialize Signed-off-by: Ayush Dattagupta <[email protected]> * remove python 3.9 testing for now Signed-off-by: Ayush Dattagupta <[email protected]> --------- Signed-off-by: Ayush Dattagupta <[email protected]>
No description provided.