Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue 46 #186

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix for issue 46 #186

wants to merge 7 commits into from

Conversation

guyknvda
Copy link
Collaborator

What does this PR do ?

enable apply sampling params for log prob computation (see issue 46)

Signed-off-by: gkoren <[email protected]>
@guyknvda guyknvda requested a review from odelalleau May 28, 2024 12:43
@github-actions github-actions bot added the Utils label May 28, 2024
@guyknvda guyknvda mentioned this pull request May 28, 2024
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

I believe we're getting pretty close -- still a few tweaks needed to ensure it's correct, but almost there :D

examples/nlp/gpt/conf/gpt_ppo_actor.yaml Show resolved Hide resolved
nemo_aligner/utils/distributed.py Outdated Show resolved Hide resolved
nemo_aligner/utils/distributed.py Show resolved Hide resolved
nemo_aligner/utils/distributed.py Show resolved Hide resolved
nemo_aligner/utils/distributed.py Outdated Show resolved Hide resolved
nemo_aligner/utils/distributed.py Show resolved Hide resolved
nemo_aligner/utils/distributed.py Outdated Show resolved Hide resolved
nemo_aligner/utils/distributed.py Outdated Show resolved Hide resolved
nemo_aligner/utils/distributed.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants