Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] Cherry pick 3106 #3107

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[2.5] Cherry pick 3106 #3107

merged 1 commit into from
Dec 13, 2024

Conversation

IsaacYangSLA
Copy link
Collaborator

Fixes #3093.

Description

This PR is a cherry-pick of #3106.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@IsaacYangSLA
Copy link
Collaborator Author

/build

@IsaacYangSLA IsaacYangSLA enabled auto-merge (rebase) December 13, 2024 17:22
chesterxgchen
chesterxgchen approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsaacYangSLA IsaacYangSLA merged commit 593557e into NVIDIA:2.5 Dec 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvidianz nvidianz nvidianz approved these changes

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@SYangster SYangster Awaiting requested review from SYangster

@yanchengnv yanchengnv Awaiting requested review from yanchengnv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IsaacYangSLA @chesterxgchen @nvidianz