Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] Cherry-pick Fixed broken doc ref to 'helm_chart' (#3022) [skip ci] #3032

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[2.5] Cherry-pick Fixed broken doc ref to 'helm_chart' (#3022) [skip ci] #3032

merged 1 commit into from
Oct 11, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

Cherry-pick Fixed broken doc ref to 'helm_chart' (#3022)

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh changed the title [2.5] Cherry-pick Fixed broken doc ref to 'helm_chart' (#3022) [2.5] Cherry-pick Fixed broken doc ref to 'helm_chart' (#3022) [skip ci] Oct 11, 2024
@YuanTingHsieh
Copy link
Collaborator Author

/build

IsaacYangSLA
IsaacYangSLA approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@IsaacYangSLA IsaacYangSLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@IsaacYangSLA IsaacYangSLA merged commit 139bc6a into NVIDIA:2.5 Oct 11, 2024
20 checks passed
@YuanTingHsieh YuanTingHsieh deleted the fix_helm_doc_link_25 branch October 11, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacYangSLA IsaacYangSLA IsaacYangSLA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuanTingHsieh @IsaacYangSLA @agiusa