Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] Update version and python requires #3024

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[2.5] Update version and python requires #3024

merged 1 commit into from
Oct 10, 2024

Conversation

IsaacYangSLA
Copy link
Collaborator

Description

Update the required python versions for nvflare and monai_nvflare

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@IsaacYangSLA IsaacYangSLA requested review from nvkevlu, YuanTingHsieh and chesterxgchen and removed request for nvkevlu and YuanTingHsieh October 10, 2024 16:12
chesterxgchen
chesterxgchen previously approved these changes Oct 10, 2024
View reviewed changes
nvkevlu
nvkevlu approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@nvkevlu nvkevlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@IsaacYangSLA
Copy link
Collaborator Author

/build

@IsaacYangSLA IsaacYangSLA enabled auto-merge (squash) October 10, 2024 16:30
@IsaacYangSLA IsaacYangSLA merged commit 2aede82 into NVIDIA:2.5 Oct 10, 2024
20 checks passed
@IsaacYangSLA IsaacYangSLA deleted the build_prep branch October 11, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvkevlu nvkevlu nvkevlu approved these changes

@chesterxgchen chesterxgchen chesterxgchen left review comments

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IsaacYangSLA @chesterxgchen @nvkevlu