Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] Add the hello-pt-resnet example #2955

Merged
merged 6 commits into from
Sep 26, 2024
Merged

[2.5] Add the hello-pt-resnet example #2955

merged 6 commits into from
Sep 26, 2024

Conversation

yhwen
Copy link
Collaborator

@yhwen yhwen commented Sep 20, 2024

Fixes # .

Description

Add an example to show how to wrap up the Python function into a Python class for creating an object instance to use in the job API. It uses the torchvision ResNet to replace the SImpleNetwork in the hello-pt example.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@yhwen yhwen changed the title Hello-pt-resnet -- [2.5 release] Add the hello-pt-resnet -- [2.5 release] Sep 20, 2024
@yhwen yhwen changed the title Add the hello-pt-resnet -- [2.5 release] Add the hello-pt-resnet example -- [2.5 release] Sep 20, 2024
yanchengnv
yanchengnv previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanTingHsieh YuanTingHsieh changed the title Add the hello-pt-resnet example -- [2.5 release] [2.5] Add the hello-pt-resnet example Sep 24, 2024
@YuanTingHsieh
Copy link
Collaborator

/build

@YuanTingHsieh
Copy link
Collaborator

same feedback as in #2954

@chesterxgchen
Copy link
Collaborator

/build

YuanTingHsieh
YuanTingHsieh reviewed Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content mostly good, some suggestions

examples/hello-world/hello-pt-resnet/README.md Show resolved Hide resolved
examples/hello-world/hello-pt-resnet/README.md Show resolved Hide resolved
examples/hello-world/hello-pt-resnet/src/hello-pt_cifar10_fl.py Outdated Show resolved Hide resolved
examples/hello-world/hello-pt-resnet/src/simple_network.py Outdated Show resolved Hide resolved
@YuanTingHsieh
Copy link
Collaborator

/build

@YuanTingHsieh YuanTingHsieh linked an issue Sep 26, 2024 that may be closed by this pull request
[BUG] Job config of FedJobConfig is not generated correctly #2935
Closed
@YuanTingHsieh YuanTingHsieh merged commit 23c471a into NVIDIA:2.5 Sep 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen left review comments

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@yanchengnv yanchengnv yanchengnv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Job config of FedJobConfig is not generated correctly
4 participants
@yhwen @YuanTingHsieh @chesterxgchen @yanchengnv