Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5] Cherry-pick fix doc and docstring issues (#2931) #2946

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

Fix doc and docstring issues

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

* Fix doc and docstring issues

* Address comments

---------

Co-authored-by: Sean Yang <[email protected]>
Co-authored-by: Chester Chen <[email protected]>
@YuanTingHsieh
Copy link
Collaborator Author

/build

Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chesterxgchen chesterxgchen merged commit 31f6735 into NVIDIA:2.5 Sep 17, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the fix_doc_25 branch September 17, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants