-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Tensor.dims equals the rank of the corresponding TensorView. #3117
Comments
wujingyue
added a commit
that referenced
this issue
Oct 15, 2024
Could have been caught if #3117 were fixed.
wujingyue
added a commit
that referenced
this issue
Oct 15, 2024
Could have been caught if #3117 were fixed.
wujingyue
added a commit
that referenced
this issue
Oct 15, 2024
Could have been caught if #3117 were fixed.
wujingyue
added a commit
that referenced
this issue
Oct 16, 2024
Could have been caught if #3117 were fixed.
Merged
wujingyue
pushed a commit
that referenced
this issue
Oct 17, 2024
Fixes #3117 This PR creates `verifyTensorDimensions` to check that `Tensor.dims` equals the rank of the corresponding `TensorView`. It is called in `FusionDefinition::finalizeDefinition` after `buildFusionIr`.
Is it possible to check while building the fusion IR? Most errors (shown as exceptions) I encountered happen during
verifyTensorDimensions .
(Sorry, I should have noticed the difference earlier) |
Regardless of my last comment, the verification didn't seem to kick in for the following example.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a follow-up to #3114. A bug could have been surfaced earlier if we had checked the equality.
Originally posted by @rdspring1 in #3114 (review)
The text was updated successfully, but these errors were encountered: