Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize wheels and sdist names to have only _ as PEP 625 asks #5750

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Dec 14, 2024

  • makes sure that nvidia-dali-tf-plugin-cuda110-1.44.0.tar.gz is
    using the normalized name nvidia_dali_tf_plugin_cuda110-1.44.0.tar.gz

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • makes sure that nvidia-dali-tf-plugin-cuda110-1.44.0.tar.gz is
    using the normalized name nvidia_dali_tf_plugin_cuda110-1.44.0.tar.gz

Additional information:

Affected modules and functionalities:

  • docker files
  • tests

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • DALI tf plugin and video tests
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21468739]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21468739]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21482728]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21482728]: BUILD FAILED

- makes sure that nvidia-dali-tf-plugin-cuda110-1.44.0.tar.gz is
  using the normalized name nvidia_dali_tf_plugin_cuda110-1.44.0.tar.gz

Signed-off-by: Janusz Lisiecki <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21510344]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21510344]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21510344]: BUILD PASSED

@JanuszL JanuszL merged commit 8535a3b into NVIDIA:main Dec 17, 2024
6 checks passed
@JanuszL JanuszL deleted the normalize_wheels branch December 17, 2024 10:43
JanuszL added a commit to JanuszL/DALI that referenced this pull request Dec 19, 2024
JanuszL added a commit to JanuszL/DALI that referenced this pull request Dec 19, 2024
JanuszL added a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants