-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize wheels and sdist names to have only _
as PEP 625 asks
#5750
Merged
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI MESSAGE: [21468739]: BUILD STARTED |
CI MESSAGE: [21468739]: BUILD FAILED |
JanuszL
force-pushed
the
normalize_wheels
branch
from
December 15, 2024 08:54
6c905c8
to
b967826
Compare
CI MESSAGE: [21482728]: BUILD STARTED |
CI MESSAGE: [21482728]: BUILD FAILED |
- makes sure that nvidia-dali-tf-plugin-cuda110-1.44.0.tar.gz is using the normalized name nvidia_dali_tf_plugin_cuda110-1.44.0.tar.gz Signed-off-by: Janusz Lisiecki <[email protected]>
JanuszL
force-pushed
the
normalize_wheels
branch
from
December 16, 2024 09:32
b967826
to
f52d3df
Compare
CI MESSAGE: [21510344]: BUILD STARTED |
mzient
approved these changes
Dec 16, 2024
stiepan
approved these changes
Dec 16, 2024
CI MESSAGE: [21510344]: BUILD FAILED |
CI MESSAGE: [21510344]: BUILD PASSED |
JanuszL
added a commit
to JanuszL/DALI
that referenced
this pull request
Dec 19, 2024
- followup for NVIDIA#5750 Signed-off-by: Janusz Lisiecki <[email protected]>
JanuszL
added a commit
to JanuszL/DALI
that referenced
this pull request
Dec 19, 2024
- follow-up for NVIDIA#5750 Signed-off-by: Janusz Lisiecki <[email protected]>
18 tasks
JanuszL
added a commit
that referenced
this pull request
Dec 20, 2024
) - follow-up for #5750 Signed-off-by: Janusz Lisiecki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using the normalized name nvidia_dali_tf_plugin_cuda110-1.44.0.tar.gz
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
using the normalized name nvidia_dali_tf_plugin_cuda110-1.44.0.tar.gz
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A