Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move operator<< and to_string for daliDataType_t to the global namespace. #5748

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Dec 13, 2024

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

The compiler checks for to_string and (especially) operator<< using ADL. Since dali::DALIDataType is now just a typedef to ::daliDataType_t, this results in automatically generated operator<< being used instead of the proper one.

GCC before version 12 picked the intended custom operator<<, masking the bug.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

ListTypeNames test, when compiled with clang or gcc>=12

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21424874]: BUILD STARTED

@mzient mzient merged commit f6e2c00 into NVIDIA:main Dec 13, 2024
5 of 6 checks passed
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21424874]: BUILD PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants