Move operator<<
and to_string
for daliDataType_t
to the global namespace.
#5748
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
The compiler checks for to_string and (especially)
operator<<
using ADL. Since dali::DALIDataType is now just a typedef to::daliDataType_t
, this results in automatically generatedoperator<<
being used instead of the proper one.GCC before version 12 picked the intended custom operator<<, masking the bug.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
ListTypeNames
test, when compiled with clang or gcc>=12Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A