-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usage of taskset in the TL1_decoder_perf #5738
Open
JanuszL
wants to merge
2
commits into
NVIDIA:main
Choose a base branch
from
JanuszL:update_perf_dec_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DALI uses more threads than just value in the `num_threads` argument. In effect, the actual number of CPU cores used is greater than intended. To ensure that we don't use more cores, and avoid inefficient data migration between ones affined with the GPU we test and a distant one a usage of task set is added to pin cores available for the test. Signed-off-by: Janusz Lisiecki <[email protected]>
!build |
CI MESSAGE: [21163554]: BUILD STARTED |
CI MESSAGE: [21166463]: BUILD STARTED |
mzient
approved these changes
Dec 6, 2024
mdabek-nvidia
approved these changes
Dec 6, 2024
CI MESSAGE: [21166463]: BUILD PASSED |
jantonguirao
approved these changes
Dec 9, 2024
CI MESSAGE: [21310491]: BUILD STARTED |
CI MESSAGE: [21310491]: BUILD FAILED |
CI MESSAGE: [21310491]: BUILD PASSED |
Signed-off-by: Janusz Lisiecki <[email protected]>
CI MESSAGE: [21337864]: BUILD STARTED |
CI MESSAGE: [21337976]: BUILD STARTED |
CI MESSAGE: [21337976]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
num_threads
argument. In effect, the actual number of CPU cores used is
greater than intended. To ensure that we don't use more cores,
and avoid inefficient data migration between ones affined
with the GPU we test and a distant one a usage of task set
is added to pin cores available for the test.
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
num_threads
argument. In effect, the actual number of CPU cores used is
greater than intended. To ensure that we don't use more cores,
and avoid inefficient data migration between ones affined
with the GPU we test and a distant one a usage of task set
is added to pin cores available for the test.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A