ExternalSource refactoring and fixing #5690
Open
+257
−277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzient
force-pushed
the
external_source_refactoring_and_fixes
branch
from
0a7d371
to
2d912c3
Compare
|
CI MESSAGE: [19728778]: BUILD STARTED |
|
CI MESSAGE: [19728778]: BUILD FAILED |
- refactor CachingList - use proper "item" wrapper type - remove "apprentice" and simplify lookahead logic - remove weird make_unique dependence - use r-value when recycling - refactor ExternalSource - store TensorList by value in list items - move all iteration data to one structure and queue - associate events directly with data items - use global event pool and obtain events for proper streams ---- Signed-off-by: Michal Zientkiewicz <[email protected]>
Signed-off-by: Michal Zientkiewicz <[email protected]>
Signed-off-by: Michal Zientkiewicz <[email protected]>
mzient
force-pushed
the
external_source_refactoring_and_fixes
branch
from
fcbed73
to
717a164
Compare
|
CI MESSAGE: [19730281]: BUILD STARTED |
|
CI MESSAGE: [19730281]: BUILD FAILED |
|
CI MESSAGE: [19730281]: BUILD PASSED |
mdabek-nvidia
requested changes
Oct 28, 2024
| int device_id = order.is_device() ? order.device_id() : tl_elm->data.device_id(); | ||
| cudaEvent_t event = tl_elm->GetCompletionEvent(order.device_id()); | ||
|
|
||
| if (order.device_id() != device_id_ && |
There was a problem hiding this comment.
This condition is unreadable, can you make it a function with readable name? Like is is_ambiguous_order in access_order.cc?
There was a problem hiding this comment.
Since it's done once per iteration, I think we can afford to just always go with the DeviceGuard. I couldn't make such assumptions in access_order.cc, but here it's quite different.
Alternatively, I can add an "record(cudaEvent_t)" function to AccessOrder - I'd rather not perpetuate the incidental complexity of stream handling in AccessOrder API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A