Remove usage of THRUST host&device vector #5439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanuszL
force-pushed
the
remove_thrust_sage
branch
2 times, most recently
from
c6a3dd2 to
b2bc44b
Compare
|
!build |
|
CI MESSAGE: [14417381]: BUILD STARTED |
JanuszL
changed the title
JanuszL
force-pushed
the
remove_thrust_sage
branch
from
b2bc44b to
67aa28a
Compare
mzient
reviewed
Apr 22, 2024
dali/c_api/operator_trace_test.cc
Outdated
| template<typename T> | ||
| thrust::device_vector<T> random_vector_gpu(std::mt19937 &mt, size_t size) { | ||
| thrust::device_vector<T> ret = random_vector_cpu<T>(mt, size); | ||
| Fill(ret.cpu(), gen); |
There was a problem hiding this comment.
Even better:
Suggested change
| Fill(ret.cpu(), gen); | |
| UniformRandomFill(ret.cpu(), mt, 0, 255); |
...and get rid of the dist/gen.
- as there is no guarantee that THRUST host and device vectors can be used in host-only programs this PR removes their usage from DALI Signed-off-by: Janusz Lisiecki <[email protected]>
JanuszL
force-pushed
the
remove_thrust_sage
branch
from
67aa28a to
ecec3dc
Compare
mzient
approved these changes
Apr 22, 2024
|
!build |
|
CI MESSAGE: [14418852]: BUILD STARTED |
awolant
approved these changes
Apr 22, 2024
|
CI MESSAGE: [14417381]: BUILD PASSED |
|
CI MESSAGE: [14418852]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vectors can be used in host-only programs this PR removes
their usage from DALI
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
vectors can be used in host-only programs this PR removes
their usage from DALI
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A