Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to remove duplicated logic in traverse_directories utility function #5419

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Refactor to remove duplicated logic in traverse_directories utility function #5419

merged 3 commits into from
Apr 11, 2024

Conversation

jantonguirao
Copy link
Contributor

Category:

Refactoring

Description:

Refactors to avoid duplicated code in traverse_directories implementation

Additional information:

Affected modules and functionalities:

FileReader, NumpyReader, FitsReader...

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@jantonguirao jantonguirao changed the title Remove duplicated logic in filesystem.cc Refactor to remove duplicated logic in filesystem.cc Apr 9, 2024
@jantonguirao jantonguirao changed the title Refactor to remove duplicated logic in filesystem.cc Refactor to remove duplicated logic in traverse_directories utility function Apr 9, 2024
@mzient mzient self-assigned this Apr 10, 2024
mzient
mzient reviewed Apr 10, 2024
View reviewed changes
dali/operators/reader/loader/filesystem.cc Outdated Show resolved Hide resolved
dali/operators/reader/loader/filesystem.cc Outdated Show resolved Hide resolved
dali/operators/reader/loader/filesystem.cc Show resolved Hide resolved
dali/operators/reader/loader/filesystem.cc Outdated Show resolved Hide resolved
dali/operators/reader/loader/filesystem.cc Outdated Show resolved Hide resolved
dali/operators/reader/loader/filesystem.cc Outdated Show resolved Hide resolved
dali/operators/reader/loader/filesystem.cc Outdated Show resolved Hide resolved
dali/operators/reader/loader/filesystem.cc Outdated Show resolved Hide resolved
dali/operators/reader/loader/filesystem.cc Outdated Show resolved Hide resolved
@jantonguirao
Code review fixes
07d55b2 
Signed-off-by: Joaquin Anton <[email protected]>
@jantonguirao
Add comment
501aa17 
Signed-off-by: Joaquin Anton <[email protected]>
@jantonguirao jantonguirao force-pushed the traverse_directories_refactor branch from c6ea4c1 to 501aa17 Compare April 10, 2024 08:19
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14130197]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14130197]: BUILD PASSED

@jantonguirao jantonguirao merged commit 2780449 into NVIDIA:main Apr 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banasraf banasraf banasraf approved these changes

@mzient mzient mzient approved these changes

Assignees

@mzient mzient

@banasraf banasraf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jantonguirao @dali-automaton @mzient @banasraf