Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VFR detection #3921

Merged
merged 24 commits into from
May 26, 2022
Merged

Add VFR detection #3921

merged 24 commits into from
May 26, 2022

Conversation

awolant
Copy link
Contributor

@awolant awolant commented May 20, 2022

Category:

New Feature

Description:

It adds detection of whether decoded video file is variable frame rate or not and ability to access this information. It is done based on the video file index. we go through the index and check time differences between the frames. If there are any differences decoded file is VFR.

This check will be optimized in the future. Goal for this PR was to add a check that works in every scenario.

Additional information:

Affected modules and functionalities:

FramesDecoder and its tests.

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-2798

awolant added 24 commits May 10, 2022 17:03
Signed-off-by: Albert Wolant <[email protected]>
Signed-off-by: Albert Wolant <[email protected]>
Signed-off-by: Albert Wolant <[email protected]>
Signed-off-by: Albert Wolant <[email protected]>
Signed-off-by: Albert Wolant <[email protected]>
Signed-off-by: Albert Wolant <[email protected]>
Signed-off-by: Albert Wolant <[email protected]>
Signed-off-by: Albert Wolant <[email protected]>
Signed-off-by: Albert Wolant <[email protected]>
Signed-off-by: Albert Wolant <[email protected]>
Signed-off-by: Albert Wolant <[email protected]>
Signed-off-by: Albert Wolant <[email protected]>
@awolant
Copy link
Contributor Author

awolant commented May 25, 2022

!build

@awolant awolant changed the title [WIP] Add VFR detection Add VFR detection May 25, 2022
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4927337]: BUILD STARTED

@awolant awolant marked this pull request as ready for review May 25, 2022 08:43
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4927337]: BUILD PASSED

@awolant awolant merged commit 77f4882 into NVIDIA:main May 26, 2022
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
Add VFR check to FramesDecoder.

Signed-off-by: Albert Wolant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants