Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to the Github actions #272

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

karlhigley
Copy link
Contributor

No description provided.

This leads to duplicate test runs when PRs get merged to `main`, since tests also run on pushes to `main`.
This action doesn't seem to be running on PRs, so making it match an action that does run.
@karlhigley karlhigley added chore Maintenance for the repository ci labels Jan 17, 2023
@karlhigley karlhigley added this to the Merlin 23.02 milestone Jan 17, 2023
@karlhigley karlhigley self-assigned this Jan 17, 2023
This action still isn't running, even after adjusting the rules that trigger it. Apparently there have been some issues with parsing job names etc containing dashes (which are a special character in YAML.)
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/systems/review/pr-272

@karlhigley karlhigley merged commit 2ebcc14 into NVIDIA-Merlin:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance for the repository ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants