fix for faiss artifact path from config #216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run the faiss operator as part of a triton ensemble, the operator will receive an index path that already has the index file name in it. We need to check if the artifact_path supplied is a file path or a directory path. If it is a file path we need to remove the file portion otherwise, use the entire artifact path supplied. This is an issue coming up in the merlin unit tests (NVIDIA-Merlin/Merlin#705 (comment)).